Skip to content

[Merged by Bors] - chore: deprecate Ordinal.one_ne_zero → _root_.one_ne_zero#39240

Closed
vihdzp wants to merge 3 commits into
leanprover-community:masterfrom
vihdzp:onenezero
Closed

[Merged by Bors] - chore: deprecate Ordinal.one_ne_zero → _root_.one_ne_zero#39240
vihdzp wants to merge 3 commits into
leanprover-community:masterfrom
vihdzp:onenezero

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented May 12, 2026

Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory labels May 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

PR summary 7beb20a061

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

No changes to strong technical debt.
No changes to weak technical debt.

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 14, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts Bot commented May 14, 2026

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 14, 2026
ocfnash
ocfnash approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 14, 2026
mathlib-bors Bot pushed a commit that referenced this pull request May 14, 2026
@vihdzp
chore: deprecate Ordinal.one_ne_zero → _root_.one_ne_zero (#39240)
398f01d
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: deprecate Ordinal.one_ne_zero → _root_.one_ne_zero [Merged by Bors] - chore: deprecate Ordinal.one_ne_zero → _root_.one_ne_zero May 14, 2026
@mathlib-bors mathlib-bors Bot closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash ocfnash approved these changes

@plp127 plp127 plp127 approved these changes

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vihdzp @ocfnash @plp127